Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DataLoader2 seed = 0 bug and clean up unused codes #1098

Closed
wants to merge 1 commit into from
Closed

Fix DataLoader2 seed = 0 bug and clean up unused codes #1098

wants to merge 1 commit into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Mar 17, 2023 •
edited
Loading

Stack from ghstack:

Fixes #1097

  1. Fixes the bug in Potential bug in DataLoader2 when seed = 0 #1097
  2. Minor clean up of unused code

Differential Revision: D44184683

NivekT added a commit that referenced this pull request Mar 17, 2023
@NivekT
Fix DataLoader2 seed = 0 bug and clean up unused codes
a5674cd 
ghstack-source-id: 6bfab020b831c801efb3a9d5916cec663231ad70
Pull Request resolved: #1098
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2023
@NivekT
Copy link
Contributor Author

NivekT commented Mar 17, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NivekT NivekT requested a review from ejguan March 17, 2023 22:00
@NivekT NivekT added the topic: bug fixes topic category label Mar 17, 2023
@NivekT NivekT changed the title Fix DataLoader2 seed = 0 bug and clean up unused codes Fix DataLoader2 seed = 0 bug and clean up unused codes Mar 17, 2023
ejguan
ejguan approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging out this issue and fix it.

@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in fd51f95.

@NivekT NivekT added this to the 0.6.1 milestone Mar 20, 2023
@NivekT NivekT mentioned this pull request Mar 20, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/NivekT/114/head branch March 24, 2023 14:20
NivekT added a commit that referenced this pull request Apr 19, 2023
@NivekT
Fix DataLoader2 seed = 0 bug and clean up unused codes (#1098)
9179db1 
Summary: Pull Request resolved: #1098

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D44184683

Pulled By: NivekT

fbshipit-source-id: d8f5391f5aeb68ebb066133d0f04541ee5bfe89c
@NivekT NivekT mentioned this pull request Apr 19, 2023
Merged
ejguan pushed a commit that referenced this pull request Apr 20, 2023
@NivekT @ejguan
Fix DataLoader2 seed = 0 bug and clean up unused codes (#1098)
aff31f9 
Summary: Pull Request resolved: #1098

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D44184683

Pulled By: NivekT

fbshipit-source-id: d8f5391f5aeb68ebb066133d0f04541ee5bfe89c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejguan ejguan ejguan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged topic: bug fixes topic category
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@NivekT @facebook-github-bot @ejguan