Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataPipe] Implement pause/resume for FullSync #1130

Closed
wants to merge 3 commits into from
Closed

[DataPipe] Implement pause/resume for FullSync #1130

wants to merge 3 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Apr 14, 2023 •
edited
Loading

NivekT added a commit that referenced this pull request Apr 14, 2023
@NivekT
[DataPipe] Implement pause/resume for FullSync
1cc4113 
ghstack-source-id: 22d89d6f359ac2b9b2ef269707db589877ff0893
Pull Request resolved: #1130
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 14, 2023
@NivekT NivekT changed the title [DataPipe] Implement pause/resume for FullSync [DataPipe] Implement pause/resume for FullSync Apr 14, 2023
@NivekT NivekT requested a review from ejguan April 14, 2023 21:29
@NivekT
Copy link
Contributor Author

NivekT commented Apr 14, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

NivekT added a commit that referenced this pull request Apr 14, 2023
@NivekT
[DataPipe] Implement pause/resume for FullSync
e08b1b4 
ghstack-source-id: e2d3011b0bacab676048df4a438b0387057e0fae
Pull Request resolved: #1130
@NivekT
Copy link
Contributor Author

NivekT commented Apr 14, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ejguan
ejguan approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the implementation doesn't invalidate the timeout from FullSync (if not all of ranks have received data at the same iteration), it should be good. Stamping on it and pls test it with the removing delegation PR.

NivekT added a commit that referenced this pull request Apr 20, 2023
@NivekT
[DataPipe] Implement pause/resume for FullSync
f58eaf3 
ghstack-source-id: 922f14802e3c6182aeaadb2a51327cf802a1105b
Pull Request resolved: #1130
@NivekT
Copy link
Contributor Author

NivekT commented Apr 20, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in 3e7eaae.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/121/head branch May 5, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejguan ejguan ejguan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NivekT @facebook-github-bot @ejguan