[DataPipe] Fix FullSync shutdown hanging issue while paused #1153
Conversation
[ghstack-poisoned]
ghstack-source-id: 098b11f30792ceca6b68b93fd98d091a5e6cad19 Pull Request resolved: #1153
facebook-github-bot
added
the
CLA Signed
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| dp3.pause() | ||
| it2 = iter(dp3) # Reset | ||
| next(it2) | ||
|
|
There was a problem hiding this comment.
Is this test failing without the patch?
There was a problem hiding this comment.
Can you add a test for DataLoader2 with fullsync?
There was a problem hiding this comment.
Yea, it fails without the patch.
There was a problem hiding this comment.
I can't really add a DataLoader2 test because DistributedRS currently doesn't support pause....
I will have to add that separately. Let me know if I should land this as it is or add that on top of this.
Differential Revision: [D45610885](https://our.internmc.facebook.com/intern/diff/D45610885) [ghstack-poisoned]
ghstack-source-id: e8353cec63f57df560d6afdc08012ddf1dd572c5 Pull Request resolved: #1153
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Before this PR, the executor within FullSync fails to shutdown if it were currently paused. This PR allows shutdown without submitting additional jobs. Differential Revision: [D45610885](https://our.internmc.facebook.com/intern/diff/D45610885) [ghstack-poisoned]
ghstack-source-id: f840643e4276fcccb1b7c8b36094e4848a6f0de2 Pull Request resolved: #1153
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Before this PR, the executor within FullSync fails to shutdown if it were currently paused. This PR allows shutdown without submitting additional jobs. Differential Revision: [D45610885](https://our.internmc.facebook.com/intern/diff/D45610885) [ghstack-poisoned]
ghstack-source-id: 723f7d11ac21b818715cf98d00d5d24d55be4301 Pull Request resolved: #1153
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Stack from ghstack:
Before this PR, the executor within FullSync fails to shutdown if it were currently paused. This PR allows shutdown without submitting additional jobs.
Differential Revision: D45610885