Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataPipe] Cancel future object and always run callback in FullSync during shutdown #1171

Closed
wants to merge 3 commits into from
Closed

[DataPipe] Cancel future object and always run callback in FullSync during shutdown #1171

wants to merge 3 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented May 24, 2023 •
edited
Loading

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 24, 2023
NivekT added a commit that referenced this pull request May 24, 2023
@NivekT
[DataPipe] Cancel future object in FullSync during shutdown
c6e909b 
ghstack-source-id: 6a928975e5c5dfbb4ae7c71074dd12356968bfc0
Pull Request resolved: #1171
NivekT added a commit that referenced this pull request May 24, 2023
@NivekT
[DataPipe] Cancel future object and always run callback in FullSync d…
7e7ad98 
…uring shutdown

ghstack-source-id: f792cd799d87da312304c25ea466848666eff334
Pull Request resolved: #1171
@NivekT NivekT changed the title [DataPipe] Cancel future object in FullSync during shutdown [DataPipe] Cancel future object and always run callback in FullSync during shutdown May 24, 2023
@NivekT
Copy link
Contributor Author

NivekT commented May 24, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NivekT
Update on "[DataPipe] Cancel future object and always run callback in…
611fecc 
… FullSync during shutdown"

Differential Revision: [D46157349](https://our.internmc.facebook.com/intern/diff/D46157349)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request May 24, 2023
@NivekT
[DataPipe] Cancel future object and always run callback in FullSync d…
070945e 
…uring shutdown

ghstack-source-id: e1e035dab4e80408f162daea71bbd00020452b03
Pull Request resolved: #1171
@NivekT
Copy link
Contributor Author

NivekT commented May 24, 2023

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@NivekT merged this pull request in 120d291.

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/126/head branch May 29, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejguan ejguan ejguan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NivekT @facebook-github-bot @ejguan