Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] update CI python versions #1319

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

andrewkho
Copy link
Contributor

@andrewkho andrewkho commented Sep 25, 2024

PyTorch 2.5 supports 3.9<=python<=3.12 (3.13 experimental). Updating our CI to match.

To save our CI costs, we're not including tests for python > 3.9 for any datapipes code, only for stateful dataloader

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2024
Copy link

pytorch-bot bot commented Sep 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1319

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ 1 Pending, 4 Unrelated Failures

As of commit e117505 with merge base 8b6e903 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ramanishsingh
Copy link
Contributor

LGTM!
Just one quick question, do we also need to update

Copy link
Contributor

@divyanshk divyanshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ramanishsingh
Copy link
Contributor

ramanishsingh commented Sep 25, 2024

Do we need to update this line?

@unittest.skipIf(sys.version_info < (3, 8), "Torch Elastic requires Python >= 3.8")

Otherwise, looks good :)

@andrewkho
Copy link
Contributor Author

Do we need to update this line?

@unittest.skipIf(sys.version_info < (3, 8), "Torch Elastic requires Python >= 3.8")

Otherwise, looks good :)

I don't think this needs to change, i'm not sure it's true that they only support 3.9+

@andrewkho andrewkho merged commit a629426 into main Sep 25, 2024
43 of 47 checks passed
@andrewkho andrewkho deleted the andrewkh/update-ci-python-versions branch September 26, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants