Fix nightly build. They've been failing due to missing secrets #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
andrewkho
force-pushed
the
andrewkh/fix-nightly
branch
from
720d72e
to
1deb432
Compare
andrewkho
force-pushed
the
andrewkh/fix-nightly
branch
from
1deb432
to
b318ac6
Compare
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1325
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b318ac6 with merge base ff01a06 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if CI will succeed without this, I don't see it referenced in many other pytorch repos though, and none of our tests which build seem to include it either.
From this workflow:
https://github.com/pytorch/data/actions/workflows/nightly_release.yml
Invalid workflow file: .github/workflows/nightly_release.yml#L18
The workflow is not valid. .github/workflows/nightly_release.yml (Line: 18, Col: 41): Invalid secret, PYTORCH_BINARY_AWS_ACCESS_KEY_ID is not defined in the referenced workflow. .github/workflows/nightly_release.yml (Line: 19, Col: 45): Invalid secret, PYTORCH_BINARY_AWS_SECRET_ACCESS_KEY is not defined in the referenced workflow.
Update digging through blame, I can see that test_release and pull_release had these keys dropped as part of this PR, probably just missed the nightly_release update: de5791b