-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup DataLoader 2 #1329
Cleanup DataLoader 2 #1329
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1329
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4b13f2f with merge base 6b762ba (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do other references to torchdata.datapipes in this file need to stay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll just delete the whole thing in one go, i wanted to try and split it up into 2-ish PRs (dlv2 and datapipes) so we can at least have some partial rollback if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, in that case maybe we want to update the PR title?
Accepting, since tests seem to pass (except some Meta specific bots).
@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
4b13f2f
to
edff40a
Compare
@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@andrewkho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Starting off the cleanup by deleting DataLoader2, CI files, and a bunch of tests