Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decompressor bzip2 support #312

Closed
wants to merge 8 commits into from

Conversation

lezwon
Copy link
Contributor

@lezwon lezwon commented Mar 20, 2022

Fixes #309

Changes

  • Added bzip2 support in decompressor
  • Added Bz2FileLoader

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 20, 2022
@lezwon lezwon changed the title 309 decompressor bzip2 support decompressor bzip2 support Mar 20, 2022
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for submitting this PR!

Just a few nit inline comments.

Also, can you add the new DataPipe to the serialization test?

Add (iterdp.Bz2FileLoader, None, (), {}), here (after BucketBatcher):

def test_serializable(self):
picklable_datapipes: List = [
(iterdp.BucketBatcher, IterableWrapper([0, 0, 0, 0, 0, 0, 0]), (5,), {}),
(

And before Decompressor, add iterdp.Bz2FileLoader,:

dp_skip_comparison = {
iterdp.Decompressor,

docs/source/torchdata.datapipes.iter.rst Outdated Show resolved Hide resolved
torchdata/datapipes/iter/__init__.pyi Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NivekT
Copy link
Contributor

NivekT commented Mar 21, 2022

Hi @lezwon, can you rebase this PR? This is because __init__.pyi has been removed by another PR, so I need a rebase before I can merge. Thanks!

@lezwon lezwon force-pushed the 309-decompressor-bzip2-support branch from d56727f to 83db89d Compare March 22, 2022 00:05
@facebook-github-bot
Copy link
Contributor

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@lezwon
Copy link
Contributor Author

lezwon commented Mar 23, 2022

@NivekT I see some internal tests have failed. Can you help me out here so I can fix them?

@NivekT
Copy link
Contributor

NivekT commented Mar 23, 2022

@NivekT I see some internal tests have failed. Can you help me out here so I can fix them?

Everything is fine. Thanks for double-checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for bzip2 decompression in Decompressor
3 participants