Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing tutorial with DataLoader #458

Closed
wants to merge 3 commits into from
Closed

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented May 24, 2022

Stack from ghstack:

Updating the tutorial and README with more relevant/correct information. Minor fix to one part of MapDataPipe documentation as well.

Fixes #352

Differential Revision: D36645515

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 24, 2022
NivekT added a commit that referenced this pull request May 24, 2022
ghstack-source-id: 0a947cba5f68bf8699ab66dda09470ae98809ee9
Pull Request resolved: #458
@NivekT
Copy link
Contributor Author

NivekT commented May 24, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@NivekT
Copy link
Contributor Author

NivekT commented May 24, 2022

Here is the rendered page:

Screen Shot 2022-05-24 at 6 15 27 PM
Screen Shot 2022-05-24 at 6 15 44 PM
Screen Shot 2022-05-24 at 6 15 50 PM

Updating the tutorial and README with more relevant/correct information

Fixes #352 

Differential Revision: [D36645515](https://our.internmc.facebook.com/intern/diff/D36645515)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request May 24, 2022
ghstack-source-id: d68b3a362e82101d53bf49c6c380828aee634682
Pull Request resolved: #458
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this detailed documents for users. I do have a few comments below.

README.md Outdated Show resolved Hide resolved
docs/source/tutorial.rst Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Updating the tutorial and README with more relevant/correct information. Minor fix to one part of `MapDataPipe` documentation as well.

Fixes #352 

Differential Revision: [D36645515](https://our.internmc.facebook.com/intern/diff/D36645515)

[ghstack-poisoned]
NivekT added a commit that referenced this pull request May 25, 2022
ghstack-source-id: 75e1c26d10561f1329ede0097f36a78b32e10bb9
Pull Request resolved: #458
@NivekT NivekT requested a review from ejguan May 25, 2022 17:49
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your work. This looks amazing.

@NivekT
Copy link
Contributor Author

NivekT commented May 25, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@Sino-Huang
Copy link

hello, the new tutorial miss the worker_init_fn part.
please check

@NivekT
Copy link
Contributor Author

NivekT commented Jun 24, 2022

hello, the new tutorial miss the worker_init_fn part. please check

Hi, that part has been removed because we have made changes for the next release (0.4.0, PyTorch Core 1.12.0), such that passing in work_init_fn for sharding should no longer be needed. Let me know if you have any question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants