Update tutorial about placing sharding_filter #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Jun 1, 2022
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Jun 2, 2022
Summary: See the feedback from a user: pytorch#454 (comment) We should explicitly ask users to place `sharding_filter` as early as possible. Pull Request resolved: pytorch#487 Reviewed By: wenleix Differential Revision: D36812259 Pulled By: ejguan fbshipit-source-id: 4c983f3216a80be398f85b20871e65b0e41627e0
ejguan
added a commit
that referenced
this pull request
Jun 2, 2022
Summary: See the feedback from a user: #454 (comment) We should explicitly ask users to place `sharding_filter` as early as possible. Pull Request resolved: #487 Reviewed By: wenleix Differential Revision: D36812259 Pulled By: ejguan fbshipit-source-id: 4c983f3216a80be398f85b20871e65b0e41627e0
bushshrub
pushed a commit
to bushshrub/data
that referenced
this pull request
Jun 2, 2022
Summary: See the feedback from a user: pytorch#454 (comment) We should explicitly ask users to place `sharding_filter` as early as possible. Pull Request resolved: pytorch#487 Reviewed By: wenleix Differential Revision: D36812259 Pulled By: ejguan fbshipit-source-id: 4c983f3216a80be398f85b20871e65b0e41627e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the feedback from a user: #454 (comment)
We should explicitly recommend users to place
sharding_filteras early as possible.