Add list_file() functional API to FSSpecFileLister and IoPathFileLister (#463) #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (pytorch#463) Summary: Fixes pytorch#387 ### Changes - Adds `list_file()` method on `IoPathFileListerIterDataPipe` - Adds `list_file()` method on `FSSpecFileListerIterDataPipe` - Add tests for those methods #### Additional comments I feel as if the implementation is quite naive. Would appreciate any feedback on it. Pull Request resolved: pytorch#463 Reviewed By: NivekT Differential Revision: D36777142 Pulled By: ejguan fbshipit-source-id: 1c4474776f3fcd377ae545bd8bd7bf26d0b2fa88
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref on main branch: #463
Summary:
Fixes #387
Changes
list_file()method onIoPathFileListerIterDataPipelist_file()method onFSSpecFileListerIterDataPipeAdditional comments
I feel as if the implementation is quite naive. Would appreciate any feedback on it.
Pull Request resolved: #463
Reviewed By: NivekT
Differential Revision: D36777142
Pulled By: ejguan
fbshipit-source-id: 1c4474776f3fcd377ae545bd8bd7bf26d0b2fa88