Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to avoid lambdas #524

Closed
wants to merge 2 commits into from
Closed

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Jun 20, 2022

Stack from ghstack:

This allow these examples to work with multiprocessing even without dill installed.

Differential Revision: D37286086

NivekT added a commit that referenced this pull request Jun 20, 2022
ghstack-source-id: 9f7d9767a47fa07e4b4f643c62947e1f6e3db76d
Pull Request resolved: #524
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2022
NivekT added a commit that referenced this pull request Jun 20, 2022
ghstack-source-id: eb45fd233c5ab544548ed4506e2e77b073b217ed
Pull Request resolved: #524
@NivekT NivekT requested a review from ejguan June 20, 2022 17:53
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you for fixing them!

@NivekT
Copy link
Contributor Author

NivekT commented Jun 20, 2022

@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ejguan
Copy link
Contributor

ejguan commented Jun 20, 2022

You can still cherry-pick this PR. PyTorch core postponed the release date.

NivekT added a commit that referenced this pull request Jun 20, 2022
Summary:
Pull Request resolved: #524

This allow these examples to work with multiprocessing even without `dill` installed.

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D37286086

Pulled By: NivekT

fbshipit-source-id: 52c859097f2d3b14d3b78d752e1f01ff5574dca5
NivekT added a commit that referenced this pull request Jun 20, 2022
Summary:
Pull Request resolved: #524

This allow these examples to work with multiprocessing even without `dill` installed.

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D37286086

Pulled By: NivekT

fbshipit-source-id: 52c859097f2d3b14d3b78d752e1f01ff5574dca5
@facebook-github-bot facebook-github-bot deleted the gh/NivekT/81/head branch June 24, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants