Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add README for DataLoader2 #526

Closed
wants to merge 1 commit into from
Closed

Add README for DataLoader2 #526

wants to merge 1 commit into from

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented Jun 20, 2022 •
edited
Loading

Add brief description of DataLoader2 and related components.

NivekT
NivekT approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! Just some nit comments for clarity.

Adding a quick code snippet with DataLoader2 in use with MultiprocessingReadService may be helpful for users as well, but we can also wait until it further matures and add a complete tutorial then.

torchdata/dataloader2/README.md Outdated Show resolved Hide resolved
torchdata/dataloader2/README.md Outdated Show resolved Hide resolved
torchdata/dataloader2/README.md Show resolved Hide resolved
torchdata/dataloader2/README.md Outdated Show resolved Hide resolved
torchdata/dataloader2/README.md Show resolved Hide resolved
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2022
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ejguan added a commit to ejguan/data that referenced this pull request Jun 21, 2022
@ejguan
Add README for DataLoader2 (pytorch#526)
48f98b6 
Summary:
Add brief description of `DataLoader2` and related components.

Pull Request resolved: pytorch#526

Reviewed By: NivekT

Differential Revision: D37315170

Pulled By: ejguan

fbshipit-source-id: 9886fb60c48870815c4e8242eb46e69031abba9a
@ejguan ejguan mentioned this pull request Jun 21, 2022
Merged
ejguan added a commit that referenced this pull request Jun 21, 2022
@ejguan
Add README for DataLoader2 (#526)
f856e0f 
Summary:
Add brief description of `DataLoader2` and related components.

Pull Request resolved: #526

Reviewed By: NivekT

Differential Revision: D37315170

Pulled By: ejguan

fbshipit-source-id: 9886fb60c48870815c4e8242eb46e69031abba9a
@ejguan ejguan mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NivekT NivekT NivekT approved these changes

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ejguan @facebook-github-bot @NivekT