Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for S3 DataPipes #534

Closed
wants to merge 1 commit into from

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented Jun 22, 2022

Fixes #523

  • Make in-line doc as the single source of truth
  • Add sharding and shuffle to the example for distributed training
  • Rephrase each arguments based on the offline discussion with @ydaiming

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2022
@ejguan ejguan requested review from ydaiming and NivekT June 22, 2022 16:37
@ejguan ejguan mentioned this pull request Jun 22, 2022
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

torchdata/datapipes/iter/load/README.md Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ejguan added a commit to ejguan/data that referenced this pull request Jun 23, 2022
Summary:
Fixes pytorch#523

- Make in-line doc as the single source of truth
- Add `sharding` and `shuffle` to the example for distributed training
- Rephrase each arguments based on the offline discussion with ydaiming

Pull Request resolved: pytorch#534

Reviewed By: NivekT

Differential Revision: D37348999

Pulled By: ejguan

fbshipit-source-id: 6cf76a26bdeeb0842aff92ca9b0be53801acb29f
ejguan added a commit that referenced this pull request Jun 23, 2022
Summary:
Fixes #523

- Make in-line doc as the single source of truth
- Add `sharding` and `shuffle` to the example for distributed training
- Rephrase each arguments based on the offline discussion with ydaiming

Pull Request resolved: #534

Reviewed By: NivekT

Differential Revision: D37348999

Pulled By: ejguan

fbshipit-source-id: 6cf76a26bdeeb0842aff92ca9b0be53801acb29f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to create a DataLoader when reading data from S3
4 participants