-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for S3 DataPipes #534
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jun 22, 2022
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
NivekT
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Jun 23, 2022
Summary: Fixes pytorch#523 - Make in-line doc as the single source of truth - Add `sharding` and `shuffle` to the example for distributed training - Rephrase each arguments based on the offline discussion with ydaiming Pull Request resolved: pytorch#534 Reviewed By: NivekT Differential Revision: D37348999 Pulled By: ejguan fbshipit-source-id: 6cf76a26bdeeb0842aff92ca9b0be53801acb29f
ejguan
added a commit
that referenced
this pull request
Jun 23, 2022
Summary: Fixes #523 - Make in-line doc as the single source of truth - Add `sharding` and `shuffle` to the example for distributed training - Rephrase each arguments based on the offline discussion with ydaiming Pull Request resolved: #534 Reviewed By: NivekT Differential Revision: D37348999 Pulled By: ejguan fbshipit-source-id: 6cf76a26bdeeb0842aff92ca9b0be53801acb29f
enric1994
reviewed
Jun 23, 2022
enric1994
reviewed
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #523
sharding
andshuffle
to the example for distributed training