-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to redefine cache timeout #571
Adding ability to redefine cache timeout #571
Conversation
[ghstack-poisoned]
ghstack-source-id: 48b0d5cdc8e0a1c46e4017a498f66ad2422fb228 Pull Request resolved: #571
[ghstack-poisoned]
ghstack-source-id: 9b9907fc7708b0dd3c0db24604b933ef102b5ab5 Pull Request resolved: #571
[ghstack-poisoned]
ghstack-source-id: fbda8a5f9794af5b9ade98aa1f3981c45812adae Pull Request resolved: #571
[ghstack-poisoned]
ghstack-source-id: 004abd582a60b42dbc7d678e3dcd6677b9537640 Pull Request resolved: #571
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
I just realize one general question for Adapter
. Since adapters would modify the DataPipe graph in-place, do we want to revert the modification for the DataPipe graph after one?epoch?
IMO DLv2 should apply adapter modifications once on the local copy of the graph it gets from the args. |
[ghstack-poisoned]
ghstack-source-id: b131266792bf3f3a7c6d9dec8e7451d2fb36015c Pull Request resolved: #571
[ghstack-poisoned]
ghstack-source-id: 1795da50e7121358c20285d288d8f9a29680116c Pull Request resolved: #571
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Differential Revision: [D37723437](https://our.internmc.facebook.com/intern/diff/D37723437) [ghstack-poisoned]
ghstack-source-id: 09b4f529a24692aed75c382825d530da1c81c061 Pull Request resolved: #571
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @VitalyFedyunin for adding the ability to manually set time for caching files. Just to be sure, the users can add this adapter on top of datapipe we return for datasets, in other words, we do not have to add this adapter internally in the dataset implementation right?
Correct |
Stack from ghstack (oldest at bottom):
Differential Revision: D37723437