Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataloader2 reading service docstring #581

Closed
wants to merge 1 commit into from
Closed

Fix dataloader2 reading service docstring #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torchdata/dataloader2/reading_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def initialize(self, datapipe: IterDataPipe) -> IterDataPipe:
datapipe: IterDataPipe. Original datapipe.

Return:
Adapated IterDataPipe.
Adapted IterDataPipe.

Example:
MultiProcessingReadingService finds information about sharding,
Expand Down Expand Up @@ -173,7 +173,7 @@ def __del__(self):
def finalize(self) -> None:
# TODO(VitalyFedyunin): Check if anyone stuck with messages
def clean_me(process, req_queue, res_queue):
# TODO(VitalyFedyunin): Can send terminations simulteniously
# TODO(VitalyFedyunin): Can send terminations simultaneously
# TODO(VitalyFedyunin): Make termination a function of QueueWrapperDataPipe (similar to reset)
req_queue.put(communication.messages.TerminateRequest())
_ = res_queue.get()
Expand Down