Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TarArchiveLoader to skip open for TarFile stream #679

Closed
wants to merge 3 commits into from
Closed

Fix TarArchiveLoader to skip open for TarFile stream #679

wants to merge 3 commits into from

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented Jul 25, 2022

Fixes #673

If data_stream is either a tafile.TarFile object (wrapped by StreamWrapper), TarArchiveLoader should directly load from data_stream without open it again.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2022
@ejguan ejguan mentioned this pull request Jul 25, 2022
Closed
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

NivekT
NivekT approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small nit

torchdata/datapipes/iter/util/tararchiveloader.py Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NivekT NivekT NivekT approved these changes

@VitalyFedyunin VitalyFedyunin Awaiting requested review from VitalyFedyunin

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.open_files(mode="b").decompress().load_from_tar() throws error
3 participants
@ejguan @facebook-github-bot @NivekT