Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial about shuffing before sharding #715

Closed
wants to merge 1 commit into from

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented Aug 4, 2022

Fixes #709

Per title

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 4, 2022
@ejguan ejguan requested a review from NivekT August 4, 2022 14:12
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Do you also want to mention the exception for internal use case here? Something about data being sharded prior to loading? (I'm probably poorly paraphrasing)

@ejguan ejguan force-pushed the fix_shuffle_sharding_tutorial branch from 8b9622d to d0c1f29 Compare August 4, 2022 17:58
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ejguan added a commit to ejguan/data that referenced this pull request Aug 5, 2022
Summary:
Fixes pytorch#709

Per title

Pull Request resolved: pytorch#715

Reviewed By: NivekT

Differential Revision: D38432061

Pulled By: ejguan

fbshipit-source-id: a8853a86efa9ca7ed6a9e76f0d51470d34513f48
ejguan added a commit that referenced this pull request Aug 5, 2022
Summary:
Fixes #709

Per title

Pull Request resolved: #715

Reviewed By: NivekT

Differential Revision: D38432061

Pulled By: ejguan

fbshipit-source-id: a8853a86efa9ca7ed6a9e76f0d51470d34513f48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tutorial about shuffling before sharding
3 participants