Add support to traverse all python collection objects (#84079) #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39357886 |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Sep 19, 2022
Summary: Pull Request resolved: pytorch#773 Fixes pytorch#752 This PR makes `traverse` function supporting more collections data structures from Python. The `getstate_hook` will be invoked after custom `__getstate__` function X-link: pytorch/pytorch#84079 Differential Revision: D39357886 Pulled By: ejguan fbshipit-source-id: 61f8011a028306978185cc0aa1e78b2e7b166a12
ejguan
force-pushed
the
export-D39357886
branch
from
03fec95
to
93fcede
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39357886 |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Sep 20, 2022
Summary: Pull Request resolved: pytorch#773 Fixes pytorch#752 This PR makes `traverse` function supporting more collections data structures from Python. The `getstate_hook` will be invoked after custom `__getstate__` function X-link: pytorch/pytorch#84079 Differential Revision: D39357886 Pulled By: ejguan fbshipit-source-id: b4976d225d259607a9580c2fb9c7820a3fbe85dd
ejguan
force-pushed
the
export-D39357886
branch
from
93fcede
to
1e8138d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39357886 |
Summary: Pull Request resolved: pytorch#773 Fixes pytorch#752 This PR makes `traverse` function supporting more collections data structures from Python. The `getstate_hook` will be invoked after custom `__getstate__` function X-link: pytorch/pytorch#84079 Differential Revision: D39357886 Pulled By: ejguan fbshipit-source-id: d4d1b961a933b42a27e5243c1be487c954be65a8
ejguan
force-pushed
the
export-D39357886
branch
from
1e8138d
to
2dc6056
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39357886 |
ejguan
added a commit
to ejguan/pytorch
that referenced
this pull request
Sep 21, 2022
Summary: X-link: pytorch/data#773 Fixes pytorch/data#752 This PR makes `traverse` function supporting more collections data structures from Python. The `getstate_hook` will be invoked after custom `__getstate__` function Pull Request resolved: pytorch#84079 Differential Revision: D39357886 Pulled By: ejguan fbshipit-source-id: 3c0629f7a355d2f7a67c7224a49b2b2721592778
|
This looks like a possible offender of the failures we are currently seeing in |
|
@pmeier I am investigating the internal synchronization problem. The corresponding PR from PT Core has not been landed pytorch/pytorch#84079 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #752
This PR makes
traversefunction supporting more collections data structures from Python. Thegetstate_hookwill be invoked after custom__getstate__functionX-link: pytorch/pytorch#84079
Differential Revision: D39357886
Pulled By: ejguan