Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataPipe] Small doc improvement for S3 #784

Closed
wants to merge 2 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Sep 20, 2022

Stack from ghstack:

Probably make sense to have a link to the details of setup/config. It renders as the last bullet point:

Screen Shot 2022-09-20 at 8 05 48 PM

Differential Revision: D39675196

NivekT added a commit that referenced this pull request Sep 20, 2022
ghstack-source-id: f0f7bf2c49540f65bc72ab8ceddb54418c9a99ec
Pull Request resolved: #784
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2022
@NivekT NivekT requested a review from ejguan September 20, 2022 22:25
Probably make sense to have a link to the details of setup/config.

[ghstack-poisoned]
NivekT added a commit that referenced this pull request Sep 20, 2022
ghstack-source-id: 3892ecb9a7da3e8b7833347dafae3defcfd09366
Pull Request resolved: #784
@NivekT
Copy link
Contributor Author

NivekT commented Sep 20, 2022

@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

Comment on lines +31 to +32
.. _README file:
https://github.com/pytorch/data/tree/main/torchdata/datapipes/iter/load#s3-io-datapipe-documentation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@facebook-github-bot facebook-github-bot deleted the gh/NivekT/91/head branch September 26, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants