Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 0.5.0] Adding kwargs for fs.open() in fsspec DataPipes #814

Merged
merged 1 commit into from
Oct 7, 2022
Merged

[Release 0.5.0] Adding kwargs for fs.open() in fsspec DataPipes #814

merged 1 commit into from
Oct 7, 2022

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Oct 7, 2022

Cherry-pick of #804

@NivekT
Adding kwargs for fs.open() in fsspec DataPipes (#804)
c5df338 
Summary:
Pull Request resolved: #804

Fixes #803

I left `FSSpecFileLister` untouched since I don't think it will be useful for `fs.ls()` to accept kwargs.

Test Plan: Imported from OSS

Reviewed By: ejguan

Differential Revision: D40038331

Pulled By: NivekT

fbshipit-source-id: 45232b938693690bc0906fc6240a104e80ef51f9
@NivekT NivekT requested a review from ejguan October 7, 2022 21:14
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2022
ejguan
ejguan approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ejguan ejguan merged commit 65cdd11 into release/0.5 Oct 7, 2022
@andrewkho andrewkho deleted the R0.5fsspeckwargs branch September 26, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejguan ejguan ejguan approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NivekT @ejguan @facebook-github-bot