Add DataLoader2-related online doc #817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ejguan
force-pushed
the
dataloader2_doc
branch
from
ce92e97
to
014e1cb
Compare
NivekT
approved these changes
Oct 11, 2022
docs/source/dataloader2.rst
Outdated
| @@ -0,0 +1,90 @@ | |||
| New DataLoader | |||
There was a problem hiding this comment.
Suggested change
| New DataLoader | |
| DataLoader2 |
super nit: Let's just name the page DataLoader2? feel free to ignore
There was a problem hiding this comment.
LMAO, I was thinking the same. But, I can't find a better to summarize all DataLoader2, ReadingService, etc. and we still have a specific sector called DataLoader2.
Any other suggestions? (DataLoader2 related? -> still weird) If not, I will change it to DataLoader2.
There was a problem hiding this comment.
I think just DataLoader2 should be fine.
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Oct 14, 2022
Summary: Per title You can check the generated doc in https://ejguan.github.io/dataloader2.html Pull Request resolved: pytorch#817 Reviewed By: NivekT Differential Revision: D40283927 Pulled By: ejguan fbshipit-source-id: 00679bdb2fc410c29f836835f88020349d55dc8d
ejguan
added a commit
that referenced
this pull request
Oct 14, 2022
Summary: Per title You can check the generated doc in https://ejguan.github.io/dataloader2.html Pull Request resolved: #817 Reviewed By: NivekT Differential Revision: D40283927 Pulled By: ejguan fbshipit-source-id: 00679bdb2fc410c29f836835f88020349d55dc8d
ejguan
added a commit
to ejguan/data
that referenced
this pull request
Oct 23, 2022
Summary: Per title You can check the generated doc in https://ejguan.github.io/dataloader2.html Pull Request resolved: pytorch#817 Reviewed By: NivekT Differential Revision: D40283927 Pulled By: ejguan fbshipit-source-id: 00679bdb2fc410c29f836835f88020349d55dc8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title
You can check the generated doc in https://ejguan.github.io/dataloader2.html