Apply sharding based on priority & combine DistInfo and ExtraInfo #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After pytorch/pytorch#88424 is landed, we are able to invoke
apply_sharding
by sharding levels (distributed or multiprocessing). Then, we are able to give fine-control on sharding byReadingService
.DistributedReadingService
, we will only set sharding on the distributed levelPrototypeMPReadingService
, we will set distributed sharding in the main process and set mp sharding in the worker processes. Previously, we set sharding in each worker process based on both distributed and mp information.worker_init_fn
doesn't needDistInfo
anymore. As, theDataPipe
has been distributed sharded in the main process.DistInfo
andExtraInfo
forworker_reset_fn
to synchronize the distributed seeds across distributed workers and set worker-local seeds based on both distributed and mp information.