[DataPipe] Fixing fsspec DataPipe to be compatible with new version of fsspec #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f fsspec [ghstack-poisoned]
NivekT
added a commit
that referenced
this pull request
Jan 20, 2023
…f fsspec ghstack-source-id: fa91e4dec9c48f7c5057a66e73b1bc6eb702ec93 Pull Request resolved: #957
facebook-github-bot
added
the
CLA Signed
|
@NivekT has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
SvenDS9
pushed a commit
to SvenDS9/PytorchData
that referenced
this pull request
Jan 24, 2023
…ytorch#957) Summary: Pull Request resolved: pytorch#957 Fixes pytorch#956 Context: In the old version of `fsspec`, the default argument is `detail=False` for method `ls` for the filesystem `memory`, thus it returned a list of `str`. In the new version, the default is `detail=True`, which returns list of `Dict`. Source code: https://github.com/fsspec/filesystem_spec/blob/2023.1.0/fsspec/implementations/memory.py#L34 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D42646692 Pulled By: NivekT fbshipit-source-id: 41258a5a16487303a7e6895c484794c1f1d66e39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #956
Context:
In the old version of
fsspec, the default argument isdetail=Falsefor methodlsfor the filesystemmemory, thus it returned a list ofstr. In the new version, the default isdetail=True, which returns list ofDict.Source code:
https://github.com/fsspec/filesystem_spec/blob/2023.1.0/fsspec/implementations/memory.py#L34
Differential Revision: D42646692