Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pure python platform-agnostic wheel #988

Closed
wants to merge 3 commits into from

Conversation

ejguan
Copy link
Contributor

@ejguan ejguan commented Feb 6, 2023

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2023
@ejguan ejguan changed the title Add python agnostic wheel Add pure python platform-agnostic wheel Feb 6, 2023
@ejguan ejguan marked this pull request as ready for review February 6, 2023 22:27
@facebook-github-bot
Copy link
Contributor

@ejguan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ejguan ejguan requested review from wenleix and NivekT February 6, 2023 22:33
Copy link
Contributor

@NivekT NivekT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions:

  1. Will this be the default installation going forward?
  2. Do we need to update the installation instructions in README?

@ejguan
Copy link
Contributor Author

ejguan commented Feb 6, 2023

  1. Will this be the default installation going forward?

Like I said in the issue. This wheel would be the backup package when none of platform specific wheels fit into users' machine. If pip finds any suitable wheel for the specific platform, it should install the platform-specific one.

2. Do we need to update the installation instructions in README?

No thing needs to be updated IMO.

@facebook-github-bot
Copy link
Contributor

@ejguan merged this pull request in 8ec3550.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pure python releases for platform-agnostic support
3 participants