Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak running examples without cuda #794

Merged
merged 2 commits into from
Jul 1, 2020
Merged

tweak running examples without cuda #794

merged 2 commits into from
Jul 1, 2020

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Jun 24, 2020

Tweak the run_python_examples.sh script to complete in ~5 minutes (on my machine) without CUDA. Once this is merged, we can consider adding #704 to actually run the examples as part of CI.

TBD: how do we get a pre-release version of torch/torchvision in order to test the latest HEAD? Perhaps it should be a pytorch/pytorch cron job that runs once a day or once a week?

ping @jlin27

@brianjo
Copy link
Contributor

brianjo commented Jun 24, 2020

You can install and run the nightly build using:

pip install --pre torch torchvision -f https://download.pytorch.org/whl/nightly/cu102/torch_nightly.html

Per pytorch.org install matrix. You might have to install nightlies for audio, vision and others to get this to work.

@brianjo
Copy link
Contributor

brianjo commented Jun 25, 2020

You can install and run the nightly build using:

pip install --pre torch torchvision -f https://download.pytorch.org/whl/nightly/cu102/torch_nightly.html

Per pytorch.org install matrix. You might have to install nightlies for audio, vision and others to get this to work.

Sorry, for non cuda nightly builds on Linux, the pip command is:

pip install numpy
pip install --pre torch torchvision -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html

Cheers

Copy link
Member

@soumith soumith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes to mnist and mnist_hogwild are too interfering to the spirit of the example. These are examples first, and CI tests second.

Can we find a way to make the changes to be 6 lines or less, even if it means they run for a minute each or something?

@mattip
Copy link
Contributor Author

mattip commented Jul 1, 2020

@soumith reworked dry_run handling in d0447a1

Copy link
Member

@soumith soumith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, did you locally check that no breakages got introduced?

@soumith soumith merged commit 49ec0bd into pytorch:master Jul 1, 2020
@mattip
Copy link
Contributor Author

mattip commented Jul 2, 2020

I checked that this PR did not introduce breakage by running the tests locally. There is a problem with dcgan and PyTorch 1.7: it is using a deprecated construct. When I do a PR to add CI, that will need to be fixed to make the CI pass.

Edit: qualify blanket statement, maybe I made a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants