-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak running examples without cuda #794
Conversation
You can install and run the nightly build using:
Per pytorch.org install matrix. You might have to install nightlies for audio, vision and others to get this to work. |
Sorry, for non cuda nightly builds on Linux, the pip command is: pip install numpy Cheers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes to mnist and mnist_hogwild are too interfering to the spirit of the example. These are examples first, and CI tests second.
Can we find a way to make the changes to be 6 lines or less, even if it means they run for a minute each or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, did you locally check that no breakages got introduced?
I checked that this PR did not introduce breakage by running the tests locally. There is a problem with Edit: qualify blanket statement, maybe I made a mistake. |
Tweak the
run_python_examples.sh
script to complete in ~5 minutes (on my machine) without CUDA. Once this is merged, we can consider adding #704 to actually run the examples as part of CI.TBD: how do we get a pre-release version of torch/torchvision in order to test the latest HEAD? Perhaps it should be a pytorch/pytorch cron job that runs once a day or once a week?
ping @jlin27