Arm backend: Add check to not partition ops with float64 input #10106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Float64 placeholders are not supported in the Arm backend. They will cause a crash when processed in the process_placeholder function. This patch rejects Float64 placeholders early to prevent crashes during the partition. Change-Id: I7e7c61836a7a50f29c18252819cf5e537f3b595a Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
YufengShi-dudu
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10106
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 929d35d with merge base a147346 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
MacOS fails unrelated |
zingo
approved these changes
Apr 11, 2025
zingo
approved these changes
Apr 11, 2025
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
- Float64 placeholders are not supported in the Arm backend. They will cause a crash when processed in the process_placeholder function. This patch rejects Float64 placeholders early to prevent crashes during the partition. Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
…ch#10106) - Float64 placeholders are not supported in the Arm backend. They will cause a crash when processed in the process_placeholder function. This patch rejects Float64 placeholders early to prevent crashes during the partition. Signed-off-by: Yufeng Shi <yufeng.shi@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I7e7c61836a7a50f29c18252819cf5e537f3b595a
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218