Skip to content

Get rid of NativePeer.java #11019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 21, 2025
Merged

Get rid of NativePeer.java #11019

merged 6 commits into from
May 21, 2025

Conversation

@kirklandsign
Copy link
Contributor

@kirklandsign kirklandsign commented May 20, 2025 •
edited
Loading

Adds an additional layer without clear usage

Resolved: #10456

@kirklandsign
Get rid of NativePeer.java
df90bdd 
Adds an additional layer without clear usage
@pytorch-bot
Copy link

pytorch-bot bot commented May 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11019

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit cee3159 with merge base 06b946e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign marked this pull request as ready for review May 20, 2025 22:59
@kirklandsign kirklandsign requested a review from shoumikhin as a code owner May 20, 2025 22:59
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 20, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kirklandsign kirklandsign requested a review from phaiting May 20, 2025 23:28
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 21, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 21, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 21, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 21, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 21, 2025

@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 1b063ca into main May 21, 2025
94 of 95 checks passed
@facebook-github-bot facebook-github-bot deleted the jni-layer-cpp branch May 21, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shoumikhin shoumikhin shoumikhin approved these changes

@phaiting phaiting Awaiting requested review from phaiting

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: misc Miscellaneous topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android] Get rid of NativePeer.java

4 participants

@kirklandsign @facebook-github-bot @shoumikhin