Skip to content

Add a parameter to pass tokenizer to llama QNN runner #12285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

Add a parameter to pass tokenizer to llama QNN runner #12285

merged 1 commit into from
Jul 9, 2025

Conversation

limintang
Copy link
Contributor

Differential Revision: D77910880

@limintang limintang requested a review from cccclai as a code owner July 8, 2025 21:18
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12285

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 0523319 with merge base 1ae4389 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 8, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77910880

@limintang limintang requested a review from billmguo July 8, 2025 21:18
cccclai
cccclai reviewed Jul 8, 2025
View reviewed changes
examples/qualcomm/oss_scripts/llama/runner/runner.cpp Outdated
"failed to load tokenizer %s",
tokenizer_path_.c_str());
if (tokenizer_ != nullptr) {
eos_ids->insert(200008);
Copy link
Contributor

@cccclai cccclai Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this 200008? It seems very model/tokenizer specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this 200008? It seems very model specific.

Replied in phabricator.

@limintang
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jul 8, 2025
limintang added a commit to limintang/executorch that referenced this pull request Jul 8, 2025
@limintang @facebook-github-bot
Add a parameter to pass tokenizer to llama QNN runner (pytorch#12285)
747d41b 
Summary: Pull Request resolved: pytorch#12285

Reviewed By: billmguo

Differential Revision: D77910880
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77910880

limintang added a commit to limintang/executorch that referenced this pull request Jul 8, 2025
@limintang @facebook-github-bot
Add a parameter to pass tokenizer to llama QNN runner (pytorch#12285)
e997fec 
Summary: Pull Request resolved: pytorch#12285

Reviewed By: billmguo

Differential Revision: D77910880
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77910880

limintang added a commit to limintang/executorch that referenced this pull request Jul 9, 2025
@limintang @facebook-github-bot
Add a parameter to pass tokenizer to llama QNN runner (pytorch#12285)
f17d3af 
Summary: Pull Request resolved: pytorch#12285

Reviewed By: billmguo

Differential Revision: D77910880
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77910880

cccclai
cccclai approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments!

examples/qualcomm/oss_scripts/llama/runner/runner.cpp
"failed to load tokenizer %s",
tokenizer_path_.c_str());
} else {
if (tokenizer_ != nullptr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@limintang maybe let's add a TODO or comment here such that others know the context. @haowhsu-quic @shewu-quic this is for supporting an internal model, feel free to let us know your thoughts and we can address it.

limintang added a commit to limintang/executorch that referenced this pull request Jul 9, 2025
@limintang @facebook-github-bot
Add a parameter to pass tokenizer to llama QNN runner (pytorch#12285)
17bed46 
Summary: Pull Request resolved: pytorch#12285

Reviewed By: billmguo, cccclai

Differential Revision: D77910880
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77910880

@limintang @facebook-github-bot
Add a parameter to pass tokenizer to llama QNN runner (pytorch#12285)
0523319 
Summary: Pull Request resolved: pytorch#12285

Reviewed By: billmguo, cccclai

Differential Revision: D77910880
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D77910880

@facebook-github-bot facebook-github-bot merged commit f2f2a9d into pytorch:main Jul 9, 2025
103 of 105 checks passed
Tanish2101 pushed a commit to Tanish2101/executorch that referenced this pull request Jul 9, 2025
@limintang @Tanish2101
Add a parameter to pass tokenizer to llama QNN runner
a76a0d7 
Differential Revision: D77910880

Pull Request resolved: pytorch#12285
@winskuo-quic winskuo-quic mentioned this pull request Jul 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@billmguo billmguo billmguo approved these changes

@cccclai cccclai cccclai approved these changes

@haowhsu-quic haowhsu-quic Awaiting requested review from haowhsu-quic

@shewu-quic shewu-quic Awaiting requested review from shewu-quic

@winskuo-quic winskuo-quic Awaiting requested review from winskuo-quic

@DannyYuyang-quic DannyYuyang-quic Awaiting requested review from DannyYuyang-quic

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@limintang @facebook-github-bot @billmguo @cccclai