Skip to content

Mass apply CMAKEFORMAT linter #12869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Mass apply CMAKEFORMAT linter #12869

wants to merge 3 commits into from

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jul 25, 2025

Ran lintrunner --paths-cmd "rg --files -g '*.cmake' -g '*.cmake.in' -g 'CMakeLists.txt'" --take CMAKEFORMAT -a. IIUC, our CMake files are already supposed to be formatted, but it's easy to forget.

@swolchok
Update
c61340b 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jul 25, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12869

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 4 Pending, 1 Unrelated Failure

As of commit e6d64a9 with merge base 69f3da0 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Jul 25, 2025
@swolchok
Mass apply CMAKEFORMAT linter
43353f7 
Ran `lintrunner --paths-cmd "rg --files -g '*.cmake' -g '*.cmake.in' -g 'CMakeLists.txt'" --take CMAKEFORMAT -a`. IIUC, our CMake files are already supposed to be formatted, but it's easy to forget.


ghstack-source-id: 07eb837
ghstack-comment-id: 3120541623
Pull-Request: #12869
@swolchok swolchok mentioned this pull request Jul 25, 2025
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2025
@swolchok
rebase
f7130e0 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 25, 2025
@swolchok
Mass apply CMAKEFORMAT linter
4f115b4 
Ran `lintrunner --paths-cmd "rg --files -g '*.cmake' -g '*.cmake.in' -g 'CMakeLists.txt'" --take CMAKEFORMAT -a`. IIUC, our CMake files are already supposed to be formatted, but it's easy to forget.

ghstack-source-id: 0b2f9fe
ghstack-comment-id: 3120541623
Pull-Request: #12869
@swolchok
minor lint polishing
e6d64a9 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jul 25, 2025
@swolchok
Mass apply CMAKEFORMAT linter
c723ca5 
Ran `lintrunner --paths-cmd "rg --files -g '*.cmake' -g '*.cmake.in' -g 'CMakeLists.txt'" --take CMAKEFORMAT -a`. IIUC, our CMake files are already supposed to be formatted, but it's easy to forget.

ghstack-source-id: 2517f59
ghstack-comment-id: 3120541623
Pull-Request: #12869
@swolchok
Copy link
Contributor Author

swolchok commented Jul 25, 2025

squashing into previous PR

@swolchok swolchok closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

@kirklandsign kirklandsign Awaiting requested review from kirklandsign

@lucylq lucylq Awaiting requested review from lucylq

@digantdesai digantdesai Awaiting requested review from digantdesai

@mcr229 mcr229 Awaiting requested review from mcr229

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @facebook-github-bot