Skip to content

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Aug 11, 2025

VelaIO is always 6D.

  • Update AOT handling of metadata from Vela.
  • Adds unittest to trigger 5D cases.
  • Updates EthosUBackend to read IO as 6D arrays.

Fixes #13022

cc @digantdesai @freddan80 @per @zingo

Copy link

pytorch-bot bot commented Aug 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13282

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Cancelled Job, 4 Unrelated Failures

As of commit 8581ecc with merge base 176800e (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 11, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Aug 11, 2025
@zingo
Copy link
Collaborator

zingo commented Aug 11, 2025

New Vela version that we hope fix #1302

@zingo
Copy link
Collaborator

zingo commented Aug 12, 2025

@digantdesai new Vela version that we hope fix #13022

@digantdesai
Copy link
Contributor

Yeah @apullin is trying out the new vela version 🙏

@zingo
Copy link
Collaborator

zingo commented Aug 14, 2025

As this is not merged yet we already have an even newver vela fixing another bug, depending if we see if thei has beem brought into meta or not for testing we might just update the Vela SHA in this PR. If you want us to keep this untouch @digantdesai just let us know but in that case you will get 2 Vela update PRs to juggle merge at the same time :)

@digantdesai
Copy link
Contributor

We haven't had a chance to update Vela internally. Perhaps this week - CC @apullin

If I were to guess we can just move the Vela to the newer of two SHAs, and it should be OK.

@zingo
Copy link
Collaborator

zingo commented Aug 19, 2025

Thanks, Yes, preferable latest Vela but note that Vela needs to be steped together with this PR, the 6D support is needed to be done on Executorch side to not break things.
Latest Vela fix more things then the big, so we need it anyway independent on the bugtesting.

@apullin
Copy link

apullin commented Aug 27, 2025

Just to update here - I did try out this commit and the corresponding commit it ethos-u-vela, and it did resolve the crash in the compiler for both the minimum working example and for our network that uses that pattern internally.

There are some other ongoing issues with lowering, where all the layers get rejected, but that may be due to a totally separate issue than the observed crash that kicked off this fix.

VelaIO is always 6D.
- Update AOT handling of metadata from Vela.
- Adds unittest to trigger 5D cases.
- Updates EthosUBackend to read IO as 6D arrays.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: I8d7d3a44ac84e5bb14fa27e7b7765c3b7a8ee483
@zingo
Copy link
Collaborator

zingo commented Sep 2, 2025

@oscarandersson8218 this probably need a rebase again :( now after the vela install is reworked. Sorry about that.

@oscarandersson8218
Copy link
Collaborator Author

CI failures are unrelated. @digantdesai @apullin can we merge this? It's blocking quite a few of our patches.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D81806570.

@apullin
Copy link

apullin commented Sep 5, 2025

I don't think anything on our end precludes a merge ... ?

I evaluated with the specific commit from this PR, and will continue to use it with that pinned version. So merging should not affect us. When this gets rolled into a release tag (non-rc), we'll probably just move on to that version.

@zingo zingo removed this from the 1.0.0 milestone Sep 11, 2025
digantdesai added a commit that referenced this pull request Sep 12, 2025
This is a combined version of #13282 and #14062.
The changes here should mirror #14135

Differential Revision: [D81810642](https://our.internmc.facebook.com/intern/diff/D81810642/)

[ghstack-poisoned]
digantdesai added a commit that referenced this pull request Sep 12, 2025
This is a combined version of #13282 and #14062.
The changes here should mirror #14135

Differential Revision: [D81810642](https://our.internmc.facebook.com/intern/diff/D81810642/)

ghstack-source-id: 309399055
Pull Request resolved: #14280
@zingo
Copy link
Collaborator

zingo commented Sep 13, 2025

Merged in #14293

@zingo zingo closed this Sep 13, 2025
@digantdesai
Copy link
Contributor

Thanks @zingo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arm backend: Vela internal error

5 participants