add ability to compare intermedidate outputs #13482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from kimishpatel:export-D80118857

Aug 26, 2025

Contributor

kimishpatel commented Aug 18, 2025

Summary: Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14

Differential Revision: D80118857

kimishpatel requested review from jackzhxng, larryliu0820, lucylq, mergennachin and swolchok as code owners

August 18, 2025 19:07

pytorch-bot bot commented Aug 18, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13482

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit f37613d with merge base f099cfb ():

NEW FAILURES - The following jobs have failed:

Build documentation / build (buck2) / Build doc (gh)
At least one of the pre-conditions you specified did not hold
pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (gh)
RuntimeError: Command docker exec -t dd536fa15b60ad064eade10cac784230e1bb41e7834300e318fdc77cfbe5aa72 /exec failed with exit code 1
pull / unittest-editable / macos / macos-job (gh)
backends/xnnpack/test/ops/test_sqrt.py::TestSqrt::test_fp16_sqrt

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / macos / macos-job (gh) (trunk failure)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Aug 18, 2025

This pull request was exported from Phabricator. Differential Revision: D80118857

facebook-github-bot added the fb-exported label

kimishpatel added the release notes: llm label

mergennachin requested review from Gasoonjia and Jack-Khuu

August 18, 2025 21:04

JacobSzwejbka approved these changes

View reviewed changes

kimishpatel force-pushed the export-D80118857 branch from 1606420 to 2a6376e Compare

August 23, 2025 00:15

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

2a6376e

Summary:

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

Contributor

facebook-github-bot commented Aug 23, 2025

This pull request was exported from Phabricator. Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from 2a6376e to a021686 Compare

August 25, 2025 19:07

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

a021686

Summary:

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

Contributor

facebook-github-bot commented Aug 25, 2025

This pull request was exported from Phabricator. Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from a021686 to b72a521 Compare

August 26, 2025 00:34

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

b72a521

Summary:

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80118857

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

a228946

Summary:
Pull Request resolved: pytorch#13482

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from b72a521 to a228946 Compare

August 26, 2025 00:38

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

88beb0a

Summary:

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from a228946 to 88beb0a Compare

August 26, 2025 02:36

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80118857

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

88b2fa3

Summary:
Pull Request resolved: pytorch#13482

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch 2 times, most recently from 88b2fa3 to d54edb1 Compare

August 26, 2025 14:27

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

d54edb1

Summary:

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80118857

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

d53a5ea

Summary:
Pull Request resolved: pytorch#13482

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from d54edb1 to d53a5ea Compare

August 26, 2025 14:31

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

993c5cc

Summary:

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from d53a5ea to 993c5cc Compare

August 26, 2025 17:24

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80118857

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

afb9456

Summary:
Pull Request resolved: pytorch#13482

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from 993c5cc to afb9456 Compare

August 26, 2025 17:27

kimishpatel added a commit to kimishpatel/executorch-1 that referenced this pull request


          add ability to compare intermedidate outputs (pytorch#13482)

4c25c6b

Summary:

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from afb9456 to 4c25c6b Compare

August 26, 2025 18:12


          add ability to compare intermedidate outputs (pytorch#13482)

f37613d

Summary:
Pull Request resolved: pytorch#13482

Add a path to leverage intermediate output comparator to eager_backbone_compare script

Reviewed By: YIWENX14, JacobSzwejbka

Differential Revision: D80118857

Contributor

facebook-github-bot commented Aug 26, 2025

This pull request was exported from Phabricator. Differential Revision: D80118857

kimishpatel force-pushed the export-D80118857 branch from 4c25c6b to f37613d Compare

August 26, 2025 18:18

facebook-github-bot merged commit 9053089 into pytorch:main

106 of 112 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JacobSzwejbka JacobSzwejbka approved these changes

jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

swolchok Awaiting requested review from swolchok swolchok is a code owner

mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

lucylq Awaiting requested review from lucylq lucylq is a code owner

Jack-Khuu Awaiting requested review from Jack-Khuu

Gasoonjia Awaiting requested review from Gasoonjia

Labels

CLA Signed fb-exported release notes: llm