Skip to content

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Aug 26, 2025

Stack from ghstack (oldest at bottom):

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with

Differential Revision: D70516347

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Aug 26, 2025
Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)

ghstack-source-id: 305831069
Pull Request resolved: #13717
Copy link

pytorch-bot bot commented Aug 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13717

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 5 New Failures

As of commit 4cd2f88 with merge base 8278e7b (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70516347

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Aug 26, 2025
Pull Request resolved: #13717

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4
ghstack-source-id: 305832320
@exported-using-ghexport

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70516347

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Aug 27, 2025
Pull Request resolved: #13717

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4
ghstack-source-id: 305994827
@exported-using-ghexport

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70516347

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Aug 27, 2025
Pull Request resolved: #13717

Deprecate the module class in pybindings, previously it was blocked by bundled program, and now it's resolved with https://github.com/pytorch/executorch/blob/2bb567f15a54fbc0ef621e5e85ff24e5da505b11/extension/module/bundled_module.h#L4
ghstack-source-id: 306001495
@exported-using-ghexport

Differential Revision: [D70516347](https://our.internmc.facebook.com/intern/diff/D70516347/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70516347

@lucylq lucylq changed the title Use exension module for pytbind Use extension module for pybind Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants