Skip to content

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 27, 2025

Summary

Update the selective build example and CI to use the new top-level targets, where appropriate. I've positioned the example as showcasing two flows - a standard way, using top-level targets, and appropriate for most use cases, and an advanced flow where the user creates a custom kernel target. This is mainly useful when integrating custom ops, which we can't easily integrate with top-level targets due to the inverted dependency on the user build.

I've updated the CMake to take an additional arg to specify whether or not to define a custom target and refactored to use the standard top-level target when not. I've also unified the CMake option naming with the top-level target. Finally, I've updated the CI job to cover both flows.

Tracking task: #12948.

Test plan

Changes are covered by the test selective build job.

Copy link

pytorch-bot bot commented Aug 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13741

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit aa5a45c with merge base b4e1145 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2025
@mergennachin mergennachin requested a review from psiddh August 27, 2025 21:58
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Aug 27, 2025
@GregoryComer GregoryComer force-pushed the update-selective-build branch 3 times, most recently from edbf601 to 29111dd Compare August 28, 2025 21:45
@GregoryComer GregoryComer force-pushed the update-selective-build branch from 29111dd to aa5a45c Compare August 28, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant