Skip to content

Run Llava with MultimodalRunner #14250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2025
Merged

Run Llava with MultimodalRunner #14250

merged 1 commit into from
Sep 16, 2025

Conversation

@rohansjoshi
Copy link
Contributor

@rohansjoshi rohansjoshi commented Sep 12, 2025

Summary

Run Llava model with MultimodalRunner instead of LlavaRunner

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14250

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 11 Cancelled Jobs, 61 Unrelated Failures

As of commit 2fcd5ab with merge base a9e265f (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@github-actions
Copy link

github-actions bot commented Sep 12, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin added this to the 1.0.0 milestone Sep 12, 2025
@rohansjoshi rohansjoshi marked this pull request as draft September 12, 2025 15:50
@rohansjoshi rohansjoshi marked this pull request as ready for review September 12, 2025 15:55
larryliu0820
larryliu0820 reviewed Sep 12, 2025
View reviewed changes
@mergennachin mergennachin removed this from the 1.0.0 milestone Sep 12, 2025
@rohansjoshi rohansjoshi merged commit 0f6385e into main Sep 16, 2025
222 of 296 checks passed
@rohansjoshi rohansjoshi deleted the multimodal-llava branch September 16, 2025 22:13
@rohansjoshi rohansjoshi mentioned this pull request Sep 16, 2025
Merged
rohansjoshi added a commit that referenced this pull request Sep 17, 2025
@rohansjoshi
Remove LlavaRunner (#14356)
9c12e69 
### Summary
Following up on
[#14250](#14250), remove
LlavaRunner (and llava_runner library dependency)

### Test plan
Llava CI test
@mergennachin
Copy link
Contributor

mergennachin commented Sep 17, 2025

@kirklandsign @larryliu0820 cherry-pick?

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@rohansjoshi @StrycekSimon
Run Llava with MultimodalRunner (pytorch#14250)
ae6ea38 
### Summary
Run Llava model with MultimodalRunner instead of LlavaRunner
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@rohansjoshi @StrycekSimon
Remove LlavaRunner (pytorch#14356)
5503464 
### Summary
Following up on
[pytorch#14250](pytorch#14250), remove
LlavaRunner (and llava_runner library dependency)

### Test plan
Llava CI test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@shoumikhin shoumikhin Awaiting requested review from shoumikhin

@swolchok swolchok Awaiting requested review from swolchok

@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rohansjoshi @mergennachin @larryliu0820 @jackzhxng @kirklandsign