Skip to content

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Sep 12, 2025

Summary

This is a re-land of #13923, fixing Meta-internal build errors. It looks like I just need to add the c10:: namespace to is_reduced_floating_point_v in one spot. It looks like this is defined in the executorch::runtime namespace when in portable mode, but not in ATen mode:

constexpr bool is_reduced_floating_point_v =
. Hence the internal failure when building internally in ATen mode. Not sure why it is this way, but accessing it via the c10 namespace works in all cases.

Test plan

CI. I'm importing the diff to validate correctness.

Copy link

pytorch-bot bot commented Sep 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14287

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Cancelled Jobs, 1 Unrelated Failure

As of commit bfb3fca with merge base 10e93fb (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@facebook-github-bot
Copy link
Contributor

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D82345075.

@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Sep 12, 2025
@GregoryComer GregoryComer marked this pull request as ready for review September 12, 2025 22:59
@facebook-github-bot facebook-github-bot merged commit 897b0d5 into pytorch:main Sep 13, 2025
297 of 304 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82345075

Pull Request resolved: pytorch#14287
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants