Reapply "[Windows] Run native unit tests in CI (#13923)" #14287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a re-land of #13923, fixing Meta-internal build errors. It looks like I just need to add the
c10::
namespace tois_reduced_floating_point_v
in one spot. It looks like this is defined in the executorch::runtime namespace when in portable mode, but not in ATen mode:executorch/runtime/core/exec_aten/util/scalar_type_util.h
Line 85 in 233063c
Test plan
CI. I'm importing the diff to validate correctness.