Skip to content

Conversation

@Michiel-Olieslagers
Copy link
Collaborator

@Michiel-Olieslagers Michiel-Olieslagers commented Oct 9, 2025

Currently using the generic evaluator leads to a dataset of "None" being used. This patch reverts the dataset to being defaulted to example inputs for the generic evaluator.

Change-Id: I7bdb3161d6339eadc50a1d3a73d592119fa87587

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Currently using the generic evaluator leads to a dataset of "None" being used.
This patch reverts the dataset to being defaulted to example inputs for the generic evaluator.

Change-Id: I7bdb3161d6339eadc50a1d3a73d592119fa87587
@Michiel-Olieslagers Michiel-Olieslagers added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate labels Oct 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14940

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 3 Pending, 1 Unrelated Failure

As of commit 69bb7f2 with merge base d8e07bd (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2025
@Michiel-Olieslagers Michiel-Olieslagers added release notes: none Do not include this in the release notes and removed release notes: arm Changes to the ARM backend delegate labels Oct 9, 2025
@zingo zingo changed the title Updated how generic evaluator is handled Arm backend: Updated how generic evaluator is handled Oct 9, 2025
@zingo zingo merged commit d4129b7 into pytorch:main Oct 9, 2025
295 of 307 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants