Switch ruamel-yaml default from 0.17.x to 0.18.15 #15119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkillianey
requested review from
JacobSzwejbka and
larryliu0820
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15119
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit c245d28 with merge base 519c7ff ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@mkillianey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83863515. |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
mkillianey
force-pushed
the
export-D83863515
branch
from
5cb242e to
80a98fb
Compare
mkillianey
pushed a commit
to mkillianey/executorch
that referenced
this pull request
Oct 14, 2025
Summary: Pull Request resolved: pytorch#15119 Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere. Reviewed By: parulgupta1004 Differential Revision: D83863515
mergennachin
approved these changes
Oct 14, 2025
| from executorch.exir.dialects.edge.op.api import to_variant | ||
| from executorch.exir.dialects.edge.spec.utils import get_tensor_variable_names | ||
|
|
||
| # pyre-ignore |
There was a problem hiding this comment.
why are you removing these pyre-ignores?
There was a problem hiding this comment.
Type information was not available in ruamel 0.17.x, but is in 0.18.15. (I.e., the linter complained that this directive is no longer necessary after upgrading the package)
|
@mkillianey has imported this pull request. If you are a Meta employee, you can view this in D83863515. |
larryliu0820
pushed a commit
to mkillianey/executorch
that referenced
this pull request
Oct 14, 2025
Summary: Pull Request resolved: pytorch#15119 Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere. Reviewed By: parulgupta1004 Differential Revision: D83863515
larryliu0820
force-pushed
the
export-D83863515
branch
from
f081a81 to
941d294
Compare
Summary: Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere. Reviewed By: mergennachin Differential Revision: D83863515 Pulled By: mkillianey
mkillianey
force-pushed
the
export-D83863515
branch
from
aa1cbb6 to
c245d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere.
Reviewed By: parulgupta1004
Differential Revision: D83863515