-
Notifications
You must be signed in to change notification settings - Fork 687
Switch ruamel-yaml default from 0.17.x to 0.18.15 #15119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15119
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit c245d28 with merge base 519c7ff ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@mkillianey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83863515. |
@pytorchbot label "release notes: none" |
5cb242e
to
80a98fb
Compare
Summary: Pull Request resolved: pytorch#15119 Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere. Reviewed By: parulgupta1004 Differential Revision: D83863515
from executorch.exir.dialects.edge.op.api import to_variant | ||
from executorch.exir.dialects.edge.spec.utils import get_tensor_variable_names | ||
|
||
# pyre-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you removing these pyre-ignores?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type information was not available in ruamel 0.17.x, but is in 0.18.15. (I.e., the linter complained that this directive is no longer necessary after upgrading the package)
@mkillianey has imported this pull request. If you are a Meta employee, you can view this in D83863515. |
Summary: Pull Request resolved: pytorch#15119 Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere. Reviewed By: parulgupta1004 Differential Revision: D83863515
f081a81
to
941d294
Compare
Summary: Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere. Reviewed By: mergennachin Differential Revision: D83863515 Pulled By: mkillianey
aa1cbb6
to
c245d28
Compare
Summary: Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere.
Reviewed By: parulgupta1004
Differential Revision: D83863515