Skip to content

Conversation

mkillianey
Copy link
Contributor

Summary: Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere.

Reviewed By: parulgupta1004

Differential Revision: D83863515

Copy link

pytorch-bot bot commented Oct 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15119

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c245d28 with merge base 519c7ff (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2025
Copy link

meta-codesync bot commented Oct 14, 2025

@mkillianey has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83863515.

@mkillianey
Copy link
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Oct 14, 2025
mkillianey pushed a commit to mkillianey/executorch that referenced this pull request Oct 14, 2025
Summary:
Pull Request resolved: pytorch#15119

Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere.

Reviewed By: parulgupta1004

Differential Revision: D83863515
from executorch.exir.dialects.edge.op.api import to_variant
from executorch.exir.dialects.edge.spec.utils import get_tensor_variable_names

# pyre-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you removing these pyre-ignores?

Copy link
Contributor Author

@mkillianey mkillianey Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type information was not available in ruamel 0.17.x, but is in 0.18.15. (I.e., the linter complained that this directive is no longer necessary after upgrading the package)

Copy link

meta-codesync bot commented Oct 14, 2025

@mkillianey has imported this pull request. If you are a Meta employee, you can view this in D83863515.

larryliu0820 pushed a commit to mkillianey/executorch that referenced this pull request Oct 14, 2025
Summary:
Pull Request resolved: pytorch#15119

Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere.

Reviewed By: parulgupta1004

Differential Revision: D83863515
Summary: Change the default version of ruamel-yaml from 0.17.10 to 0.18.15 everywhere.

Reviewed By: mergennachin

Differential Revision: D83863515

Pulled By: mkillianey
@larryliu0820 larryliu0820 merged commit bffb7f3 into pytorch:main Oct 15, 2025
147 of 150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants