Skip to content

Conversation

zonglinpeng
Copy link
Contributor

Summary:

Summary

This diff adds a new test for the im2row_out operator in the Cadence HiFi backend. The test is added in the test_op_im2row_out.cpp file and is compilable on both fbcode and xplat.

The test includes a new function im2row_out in the operators.h file, which is declared but not defined. The definition of this function is not provided in this diff.

The test file test_op_im2row_out.cpp includes the necessary headers and uses the gtest framework for testing. It also includes some utility functions from the executorch library.

Overall, this diff adds a new test for the im2row_out operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself.

Differential Revision: D84639802

Copy link

pytorch-bot bot commented Oct 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15123

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit db0161d with merge base 1a5eaec (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2025
Copy link

meta-codesync bot commented Oct 14, 2025

@zonglinpeng has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84639802.

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

cad-audio and others added 2 commits October 14, 2025 13:19
Summary:
im2row HiFi optimizations

Pull Request resolved: pytorch#13431

Test Plan: unit tests

Differential Revision: D82218005

Pulled By: zonglinpeng
Differential Revision: D84639743
zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Oct 14, 2025
Summary:
Pull Request resolved: pytorch#15123

### Summary

This diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend. The test is added in the `test_op_im2row_out.cpp` file and is compilable on both fbcode and xplat.

The test includes a new function `im2row_out` in the `operators.h` file, which is declared but not defined. The definition of this function is not provided in this diff.

The test file `test_op_im2row_out.cpp` includes the necessary headers and uses the `gtest` framework for testing. It also includes some utility functions from the `executorch` library.

Overall, this diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself.

Differential Revision: D84639802
Copy link
Contributor

@mcremon-meta mcremon-meta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have so much code change? Is this including docs too?

zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Oct 14, 2025
Summary:
Pull Request resolved: pytorch#15123

### Summary

This diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend. The test is added in the `test_op_im2row_out.cpp` file and is compilable on both fbcode and xplat.

The test includes a new function `im2row_out` in the `operators.h` file, which is declared but not defined. The definition of this function is not provided in this diff.

The test file `test_op_im2row_out.cpp` includes the necessary headers and uses the `gtest` framework for testing. It also includes some utility functions from the `executorch` library.

Overall, this diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself.

Reviewed By: mcremon-meta

Differential Revision: D84639802
zonglinpeng added a commit to zonglinpeng/executorch that referenced this pull request Oct 14, 2025
Summary:
Pull Request resolved: pytorch#15123

### Summary

This diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend. The test is added in the `test_op_im2row_out.cpp` file and is compilable on both fbcode and xplat.

The test includes a new function `im2row_out` in the `operators.h` file, which is declared but not defined. The definition of this function is not provided in this diff.

The test file `test_op_im2row_out.cpp` includes the necessary headers and uses the `gtest` framework for testing. It also includes some utility functions from the `executorch` library.

Overall, this diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself.

Reviewed By: mcremon-meta

Differential Revision: D84639802
Summary:
Pull Request resolved: pytorch#15123

### Summary

This diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend. The test is added in the `test_op_im2row_out.cpp` file and is compilable on both fbcode and xplat.

The test includes a new function `im2row_out` in the `operators.h` file, which is declared but not defined. The definition of this function is not provided in this diff.

The test file `test_op_im2row_out.cpp` includes the necessary headers and uses the `gtest` framework for testing. It also includes some utility functions from the `executorch` library.

Overall, this diff adds a new test for the `im2row_out` operator in the Cadence HiFi backend, but does not provide the implementation of the operator itself.

Reviewed By: mcremon-meta

Differential Revision: D84639802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants