Skip to content

Conversation

@larryliu0820
Copy link
Contributor

@larryliu0820 larryliu0820 commented Oct 24, 2025

Let's not hard code the number of nodes in the graph.

The graph of batch norm + conv looks like this after torch nightly 1015:

graph():
    %p_conv_weight : [num_users=1] = placeholder[target=p_conv_weight]
    %p_conv_bias : [num_users=1] = placeholder[target=p_conv_bias]
    %p_batch_norm_batch_norm_weight : [num_users=1] = placeholder[target=p_batch_norm_batch_norm_weight]
    %p_batch_norm_batch_norm_bias : [num_users=1] = placeholder[target=p_batch_norm_batch_norm_bias]
    %b_batch_norm_batch_norm_running_mean : [num_users=1] = placeholder[target=b_batch_norm_batch_norm_running_mean]
    %b_batch_norm_batch_norm_running_var : [num_users=1] = placeholder[target=b_batch_norm_batch_norm_running_var]
    %x : [num_users=1] = placeholder[target=x]
    %conv2d : [num_users=1] = call_function[target=torch.ops.aten.conv2d.default](args = (%x, %p_conv_weight, %p_conv_bias), kwargs = {})
    %batch_norm : [num_users=1] = call_function[target=torch.ops.aten.batch_norm.default](args = (%conv2d, %p_batch_norm_batch_norm_weight, %p_batch_norm_batch_norm_bias, %b_batch_norm_batch_norm_running_mean, %b_batch_norm_batch_norm_running_var, False, 0.1, 1e-05, True), kwargs = {})
    return (batch_norm,)

Let's not hard code the number of nodes in the graph
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15384

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 5455390 with merge base cf407fc (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2025
@larryliu0820 larryliu0820 added the release notes: none Do not include this in the release notes label Oct 24, 2025
@larryliu0820 larryliu0820 merged commit 7ce78c0 into main Oct 24, 2025
148 of 150 checks passed
@larryliu0820 larryliu0820 deleted the fix_nxp branch October 24, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants