Skip to content

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Nov 6, 2025

Add src to mypy_path to get rid of lots of missing import warnings.

Signed-off-by: per.held@arm.com
Change-Id: I4ed1a08cfe185aa956c6408fefa5aadeb567d4c1

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@perheld perheld added ciflow/trunk module: arm Issues related to arm backend release notes: none Do not include this in the release notes labels Nov 6, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15629

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 5 Unrelated Failures

As of commit 5079f4f with merge base acf5b4b (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2025
@perheld perheld force-pushed the ph-mypy-ops-mypy.ini branch from 09501c5 to b911dc5 Compare November 6, 2025 06:57
@zingo zingo requested a review from mergennachin November 6, 2025 06:57
@zingo
Copy link
Collaborator

zingo commented Nov 6, 2025

@mergennachin this helps a a lot when checking with mypy is it OK to do?
The src folders seem to be a bit of a work in progress.

@perheld perheld added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Nov 6, 2025
Add src to mypy_path to get rid of lots of missing import warnings.

Signed-off-by: per.held@arm.com
Change-Id: I4ed1a08cfe185aa956c6408fefa5aadeb567d4c1
@perheld perheld force-pushed the ph-mypy-ops-mypy.ini branch from b911dc5 to 5079f4f Compare November 6, 2025 17:15
@perheld
Copy link
Collaborator Author

perheld commented Nov 6, 2025

lintrunner-mypy is not running for this PR because no python file is changed. Is there some clever way I can force run it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants