-
Notifications
You must be signed in to change notification settings - Fork 778
Add missing Buck build targets and module exports for the cortex_m quantizer package #16370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16370
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 6 New Failures, 21 Pending, 14 Unrelated FailuresAs of commit 685dc40 with merge base 92a8ba9 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
digantdesai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review automatically exported from Phabricator review in Meta.
This PR needs a
|
d5359ec to
e53d81b
Compare
Summary: This diff adds missing Buck build targets and module exports for the cortex_m quantizer package in both xplat and fbcode. ## Rationale The recent diff-train commit D89549367 added softmax support to the cortex_m backend, which introduced new quantizer files (operator_configs.py, quantization_configs.py, quantizer.py). However, the following were missing: 1. **TARGETS files**: No Buck build targets existed for the quantizer package, making it impossible to depend on these modules from other targets 2. **__init__.py files**: No module exports existed, preventing proper Python package imports 3. **Dependency in ops/TARGETS**: The ops target was missing the quantization_configs dependency needed for the operators module ## Changes - Add `quantizer` and `quantization_configs` Buck targets to both xplat and fbcode - Add `__init__.py` with proper exports for quantizer classes and config constants - Add missing `quantization_configs` dependency to `ops/TARGETS` - Use appropriate build macros: `runtime.python_library` for xplat, `python_library` for fbcode Reviewed By: rascani, digantdesai Differential Revision: D89688088
e53d81b to
685dc40
Compare
|
New failures seem unrelated, landing |
|
This might have cause a lot of CI problems from Etrhos-U Testing a revert PR to see if that make it work. It could be something unrelated also. |
Checking if this fwd fix : #16376 fixes the issue |
Summary:
This diff adds missing Buck build targets and module exports for the cortex_m quantizer package
Rationale
The recent diff-train commit D89549367 added softmax support to the cortex_m backend, which introduced new quantizer files (operator_configs.py, quantization_configs.py, quantizer.py). However, the following were missing:
Changes
quantizerandquantization_configsBuck targets__init__.pywith proper exports for quantizer classes and config constantsquantization_configsdependency toops/TARGETSruntime.python_libraryfor xplat,python_libraryReviewed By: digantdesai
Differential Revision: D89688088