Skip to content

Conversation

@psiddh
Copy link
Contributor

@psiddh psiddh commented Dec 22, 2025

Summary:
This diff adds missing Buck build targets and module exports for the cortex_m quantizer package

Rationale

The recent diff-train commit D89549367 added softmax support to the cortex_m backend, which introduced new quantizer files (operator_configs.py, quantization_configs.py, quantizer.py). However, the following were missing:

  1. TARGETS files: No Buck build targets existed for the quantizer package, making it impossible to depend on these modules from other targets
  2. init.py files: No module exports existed, preventing proper Python package imports
  3. Dependency in ops/TARGETS: The ops target was missing the quantization_configs dependency needed for the operators module

Changes

  • Add quantizer and quantization_configs Buck targets
  • Add __init__.py with proper exports for quantizer classes and config constants
  • Add missing quantization_configs dependency to ops/TARGETS
  • Use appropriate build macros: runtime.python_library for xplat, python_library

Reviewed By: digantdesai

Differential Revision: D89688088

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16370

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 6 New Failures, 21 Pending, 14 Unrelated Failures

As of commit 685dc40 with merge base 92a8ba9 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 22, 2025
@meta-codesync
Copy link

meta-codesync bot commented Dec 22, 2025

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89688088.

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@psiddh psiddh requested a review from rascani December 22, 2025 20:59
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh psiddh changed the title Fix xplat/fbcode sync for cortex_m quantizer Add missing Buck build targets and module exports for the cortex_m quantizer package Dec 22, 2025
@psiddh psiddh force-pushed the export-D89688088 branch 2 times, most recently from d5359ec to e53d81b Compare December 22, 2025 22:24
Summary:
This diff adds missing Buck build targets and module exports for the cortex_m quantizer package in both xplat and fbcode.

## Rationale

The recent diff-train commit D89549367 added softmax support to the cortex_m backend, which introduced new quantizer files (operator_configs.py, quantization_configs.py, quantizer.py). However, the following were missing:

1. **TARGETS files**: No Buck build targets existed for the quantizer package, making it impossible to depend on these modules from other targets
2. **__init__.py files**: No module exports existed, preventing proper Python package imports
3. **Dependency in ops/TARGETS**: The ops target was missing the quantization_configs dependency needed for the operators module

## Changes

- Add `quantizer` and `quantization_configs` Buck targets to both xplat and fbcode
- Add `__init__.py` with proper exports for quantizer classes and config constants
- Add missing `quantization_configs` dependency to `ops/TARGETS`
- Use appropriate build macros: `runtime.python_library` for xplat, `python_library` for fbcode

Reviewed By: rascani, digantdesai

Differential Revision: D89688088
@psiddh
Copy link
Contributor Author

psiddh commented Dec 22, 2025

New failures seem unrelated, landing

@psiddh psiddh merged commit dafa082 into pytorch:main Dec 22, 2025
135 of 179 checks passed
@psiddh psiddh requested a review from AdrianLundell December 23, 2025 02:32
@zingo
Copy link
Collaborator

zingo commented Dec 23, 2025

This might have cause a lot of CI problems from Etrhos-U Testing a revert PR to see if that make it work. It could be something unrelated also.

See https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=(arm-backend%7Ccortex)&useRegexFilter=true

@psiddh
Copy link
Contributor Author

psiddh commented Dec 23, 2025

This might have cause a lot of CI problems from Etrhos-U Testing a revert PR to see if that make it work. It could be something unrelated also.

See https://hud.pytorch.org/hud/pytorch/executorch/main/1?per_page=50&name_filter=(arm-backend%7Ccortex)&useRegexFilter=true

Checking if this fwd fix : #16376 fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants