Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the temp allocator for backend #3490

Closed
wants to merge 1 commit into from

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented May 2, 2024

Summary: Seems like forget to pass temp allocator to BackendExecutionContext...

Differential Revision: D56893727

Copy link

pytorch-bot bot commented May 2, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3490

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e51103b with merge base b9488fe (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56893727

Summary:

Seems like forget to pass temp allocator to `BackendExecutionContext`...

Reviewed By: tarun292

Differential Revision: D56893727
@cccclai cccclai force-pushed the export-D56893727 branch from bdd121e to e51103b Compare May 3, 2024 17:02
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56893727

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 1fd80fe.

@cccclai
Copy link
Contributor Author

cccclai commented May 3, 2024

@pytorchbot cherry-pick --onto release/0.2 -c regression

pytorchbot pushed a commit that referenced this pull request May 3, 2024
Summary:
Pull Request resolved: #3490

Seems like forget to pass temp allocator to `BackendExecutionContext`...

Reviewed By: tarun292

Differential Revision: D56893727

fbshipit-source-id: 81bb1208a163220f9b4250493b06069e6329628e
(cherry picked from commit 1fd80fe)
@pytorchbot
Copy link
Collaborator

Cherry picking #3490

The cherry pick PR is at #3506 and it is recommended to link a regression cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

@cccclai cccclai mentioned this pull request May 3, 2024
dbort pushed a commit that referenced this pull request May 3, 2024
Summary:
Pull Request resolved: #3490

Seems like forget to pass temp allocator to `BackendExecutionContext`...

Reviewed By: tarun292

Differential Revision: D56893727

fbshipit-source-id: 81bb1208a163220f9b4250493b06069e6329628e
(cherry picked from commit 1fd80fe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants