Android improve prebuilt workflow and provide tutorial #3840
Conversation
kirklandsign
commented
Jun 4, 2024
kirklandsign
commented
- Don't depend on demo app. Instead, build JAR/JNI/AAR directly
- Update tutorial, example scripts for LLAMA demo app
Don't depend on demo app. Instead, build JAR/JNI/AAR directly
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3840
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit ea38c68 with merge base f184329 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
SHA is temporary! |
|
@kirklandsign has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -0,0 +1,37 @@ | |||
| # Using Android prebuilt libraries (AAR) | |||
There was a problem hiding this comment.
Can you add a link for this page from here?
https://docs-preview.pytorch.org/pytorch/executorch/3840/demo-apps-android.html?
There was a problem hiding this comment.
So far I added a link in LLAMA demo app page, because I set up LLAMA in a way that we can use either prebuilt library or locally built library.
For ExecuTorch demo app, I can't easily modify the code to let user choose between two options. Especially when the ExecuTorch demo app has Qualcomm related stuff. I feel it's risky. Then linking the prebuilt library instruction to ExecuTorch demo app page might confuse people, because they need to modify the gradle rule a bit.
Let me know what you think.
|
@kirklandsign merged this pull request in e85b52a. |
I will update it for main. I use 0.2.1 so it's easier to CP to release branch |
