Add switch for android arvr mode #7179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7179
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3132b4f with merge base 27ed99f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66737951 |
larryliu0820
approved these changes
Dec 4, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Summary: In ARVR repo Linux/Windows etc. targets generally tend to use torch deps that are appended with `ovrsource` whereas mobile targets don't use them. In order to avoid multiple symbol definitions we add another level of platform specification called `ARVR_ANDROID` which will allow us to specify a dep for ARVR Android build modes. Reviewed By: larryliu0820, dbort Differential Revision: D66737951
facebook-github-bot
force-pushed
the
export-D66737951
branch
from
d430930 to
c6dcdf5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66737951 |
Summary: In ARVR repo Linux/Windows etc. targets generally tend to use torch deps that are appended with `ovrsource` whereas mobile targets don't use them. In order to avoid multiple symbol definitions we add another level of platform specification called `ARVR_ANDROID` which will allow us to specify a dep for ARVR Android build modes. Reviewed By: larryliu0820, dbort Differential Revision: D66737951
facebook-github-bot
force-pushed
the
export-D66737951
branch
from
c6dcdf5 to
3132b4f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66737951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In ARVR repo Linux/Windows etc. targets generally tend to use torch deps that are appended with
ovrsourcewhereas mobile targets don't use them.In order to avoid multiple symbol definitions we add another level of platform specification called
ARVR_ANDROIDwhich will allow us to specify a dep for ARVR Android build modes.Reviewed By: larryliu0820
Differential Revision: D66737951