Skip to content

Conversation

Abhi-hpp
Copy link
Contributor

@Abhi-hpp Abhi-hpp commented Dec 4, 2024

Summary: Add a flag to optionally include the shader source in the generated spv and make it default on windows.

Differential Revision: D66778427

@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Dec 4, 2024
Copy link

pytorch-bot bot commented Dec 4, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7182

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e24ab26 with merge base a9565aa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 4, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

Reviewed By: SS-JIA

Differential Revision: D66778427
Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 4, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

Reviewed By: SS-JIA

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 4, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

Reviewed By: SS-JIA

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 4, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

Reviewed By: SS-JIA

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 4, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

Reviewed By: SS-JIA

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 4, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

Reviewed By: SS-JIA

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 5, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 5, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: SS-JIA

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Abhi-hpp added a commit to Abhi-hpp/executorch that referenced this pull request Dec 5, 2024
Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: SS-JIA

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

Summary:

Add a flag to optionally include the shader source in the generated spv and make it default on windows.

bypass-github-export-checks
bypass-github-pytorch-ci-checks
bypass-github-executorch-ci-checks

Reviewed By: SS-JIA

Differential Revision: D66778427
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66778427

@facebook-github-bot facebook-github-bot merged commit 0268eaa into pytorch:main Dec 6, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants