Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use-pt-pinned-commit for test-arm-{backend,reference}-delegation #7579

Merged
merged 13 commits into from
Jan 29, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 9, 2025

Stack from ghstack (oldest at bottom):

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: D67996459

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jan 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7579

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 3 Pending

As of commit a32563d with merge base 98697f6 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 9, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

@swolchok swolchok added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Jan 9, 2025
@swolchok swolchok requested review from huydhn and digantdesai January 9, 2025 23:53
@swolchok
Copy link
Contributor Author

looks like I missed a spot of include path fixing in #7040? not sure exactly why this would make it show up though. https://github.com/pytorch/executorch/actions/runs/12700684319/job/35403838935#step:14:13497

@swolchok
Copy link
Contributor Author

not sure exactly why this would make it show up though.

yep, turns out I needed to add ciflow/trunk on #7040. will fix there.

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 10, 2025
…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

swolchok added a commit that referenced this pull request Jan 28, 2025
Pull Request resolved: #7579

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263532775
@exported-using-ghexport

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
…gation"

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 28, 2025
Pull Request resolved: #7579

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67996459

@facebook-github-bot facebook-github-bot merged commit 0f96804 into gh/swolchok/127/base Jan 29, 2025
69 of 70 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/127/head branch January 29, 2025 00:39
manuelcandales pushed a commit that referenced this pull request Jan 29, 2025
Pull Request resolved: #7579

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

Co-authored-by: Scott Wolchok <swolchok@meta.com>
kirklandsign pushed a commit that referenced this pull request Jan 31, 2025
* --use-pt-pinned-commit in one-off linux jobs

Pull Request resolved: #7922

This is needed to respect the torchgen pinned commit for #7546.
ghstack-source-id: 263542478
@exported-using-ghexport

Differential Revision: [D68593517](https://our.internmc.facebook.com/intern/diff/D68593517/)

* use-pt-pinned-commit for test-arm-{backend,reference}-delegation (#8023)

Pull Request resolved: #7579

Without this, these builds don't respect the torchgen pinned commit and thus fail with #7546.
ghstack-source-id: 263542481
@exported-using-ghexport

Differential Revision: [D67996459](https://our.internmc.facebook.com/intern/diff/D67996459/)

Co-authored-by: Scott Wolchok <swolchok@meta.com>

---------

Co-authored-by: Scott Wolchok <swolchok@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants