-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ET-VK][ez] Test specific sizes of linear sizes in generated operator tests #7667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests ## Context Recent changes related to checking SPIR-V capability support at runtime have made it possible to test the 8-bit quantized linear compute shader on Android devices. Previously the test would be automatically skipped since the operator potentially uses 8-bit data types. To make the generated tests more useful, instead test real sizes of linear layer settings found in a sample model in the 8-bit linear test case. Differential Revision: [D68192068](https://our.internmc.facebook.com/intern/diff/D68192068/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7667
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit e3a4197 with merge base 01d526f (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 15, 2025
SS-JIA
added a commit
that referenced
this pull request
Jan 15, 2025
… tests ## Context Recent changes related to checking SPIR-V capability support at runtime have made it possible to test the 8-bit quantized linear compute shader on Android devices. Previously the test would be automatically skipped since the operator potentially uses 8-bit data types. To make the generated tests more useful, instead test real sizes of linear layer settings found in a sample model in the 8-bit linear test case. Differential Revision: [D68192068](https://our.internmc.facebook.com/intern/diff/D68192068/) ghstack-source-id: 261460817 Pull Request resolved: #7667
This pull request was exported from Phabricator. Differential Revision: D68192068 |
nathanaelsee
approved these changes
Jan 15, 2025
…ed operator tests" ## Context Recent changes related to checking SPIR-V capability support at runtime have made it possible to test the 8-bit quantized linear compute shader on Android devices. Previously the test would be automatically skipped since the operator potentially uses 8-bit data types. To make the generated tests more useful, instead test real sizes of linear layer settings found in a sample model in the 8-bit linear test case. Differential Revision: [D68192068](https://our.internmc.facebook.com/intern/diff/D68192068/) [ghstack-poisoned]
SS-JIA
added a commit
that referenced
this pull request
Jan 15, 2025
… tests Pull Request resolved: #7667 ## Context Recent changes related to checking SPIR-V capability support at runtime have made it possible to test the 8-bit quantized linear compute shader on Android devices. Previously the test would be automatically skipped since the operator potentially uses 8-bit data types. To make the generated tests more useful, instead test real sizes of linear layer settings found in a sample model in the 8-bit linear test case. ghstack-source-id: 261524380 @exported-using-ghexport Differential Revision: [D68192068](https://our.internmc.facebook.com/intern/diff/D68192068/)
This pull request was exported from Phabricator. Differential Revision: D68192068 |
facebook-github-bot
merged commit Jan 15, 2025
e2b8c67
into
gh/SS-JIA/167/base
43 of 47 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
January 15, 2025 17:33 — with
GitHub Actions
Inactive
SS-JIA
added a commit
that referenced
this pull request
Jan 15, 2025
… tests (#7672) Pull Request resolved: #7667 ## Context Recent changes related to checking SPIR-V capability support at runtime have made it possible to test the 8-bit quantized linear compute shader on Android devices. Previously the test would be automatically skipped since the operator potentially uses 8-bit data types. To make the generated tests more useful, instead test real sizes of linear layer settings found in a sample model in the 8-bit linear test case. ghstack-source-id: 261524380 @exported-using-ghexport Differential Revision: [D68192068](https://our.internmc.facebook.com/intern/diff/D68192068/) Co-authored-by: Stephen Jia <ssjia@meta.com>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
… tests (#7672) Pull Request resolved: #7667 ## Context Recent changes related to checking SPIR-V capability support at runtime have made it possible to test the 8-bit quantized linear compute shader on Android devices. Previously the test would be automatically skipped since the operator potentially uses 8-bit data types. To make the generated tests more useful, instead test real sizes of linear layer settings found in a sample model in the 8-bit linear test case. ghstack-source-id: 261524380 @exported-using-ghexport Differential Revision: [D68192068](https://our.internmc.facebook.com/intern/diff/D68192068/) Co-authored-by: Stephen Jia <ssjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
topic: not user facing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
Recent changes related to checking SPIR-V capability support at runtime have made it possible to test the 8-bit quantized linear compute shader on Android devices. Previously the test would be automatically skipped since the operator potentially uses 8-bit data types.
To make the generated tests more useful, instead test real sizes of linear layer settings found in a sample model in the 8-bit linear test case.
Differential Revision: D68192068