Skip to content

Conversation

pytorchbot
Copy link
Collaborator

@pytorchbot pytorchbot commented Feb 28, 2025

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #8817 by @larryliu0820
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/larryliu0820/62/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/62/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/larryliu0820/62/orig
@diff-train-skip-merge

cc @larryliu0820 @lucylq

As titled. To do this we need to refactor the arguments being passed
into `setup-linux.sh` `setup-macos.sh` and `unittest-linux.sh`
`unittest-macos.sh`.

ghstack-source-id: 19ab827
Pull Request resolved: #8817
Copy link

pytorch-bot bot commented Feb 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8855

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 10 Pending

As of commit 69fde52 with merge base 76fb844 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
@larryliu0820 larryliu0820 added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels Feb 28, 2025
@pytorchbot pytorchbot temporarily deployed to upload-benchmark-results March 1, 2025 00:41 — with GitHub Actions Inactive
@larryliu0820 larryliu0820 merged commit 86dcc3e into main Mar 1, 2025
103 of 106 checks passed
@larryliu0820 larryliu0820 deleted the gh/larryliu0820/62/orig branch March 1, 2025 00:44
@pytorchbot pytorchbot temporarily deployed to upload-benchmark-results March 1, 2025 01:07 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants