Skip to content

first crack at optimized op_where #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

first crack at optimized op_where #8861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/xnnpack/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ if(NOT CMAKE_TOOLCHAIN_FILE MATCHES ".*(iOS|ios\.toolchain)\.cmake$")
endif()

target_link_libraries(
xnn_executor_runner gflags portable_ops_lib ${xnn_executor_runner_libs}
xnn_executor_runner gflags optimized_native_cpu_ops_lib ${xnn_executor_runner_libs}
)
target_compile_options(xnn_executor_runner PUBLIC ${_common_compile_options})
endif()
Expand Down
6 changes: 6 additions & 0 deletions kernels/optimized/cpu/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ _OPTIMIZED_ATEN_OPS = (
"//executorch/kernels/portable/cpu/util:broadcast_util",
],
),
op_target(
name = "op_where",
deps = [
"//executorch/kernels/portable/cpu/util:elementwise_util",
],
),
)


Expand Down
5 changes: 5 additions & 0 deletions kernels/optimized/optimized.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,8 @@
kernels:
- arg_meta: null
kernel_name: torch::executor::opt_sub_scalar_out

- op: where.self_out
kernels:
- arg_meta: null
kernel_name: torch::executor::opt_where_out
1 change: 1 addition & 0 deletions kernels/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ set(_optimized_kernels_test_sources
"op_native_layer_norm_test.cpp"
"op_neg_test.cpp"
"op_sub_test.cpp"
"op_where_test.cpp"
"UnaryUfuncRealHBBF16ToFloatHBF16Test.cpp"
${CMAKE_CURRENT_BINARY_DIR}/include/optimized/executorch/kernels/test/supported_features.cpp
)
Expand Down
Loading